fix(designer): Prevent propagation of 401 Unauthorized status from Azure DevOps #14378

framitdavid · 2025-01-08T11:55:58Z

Description

This PR adds the AzureDevOpsTokenDelegatingHandler to prevent the propagation of a 401 Unauthorized status from Azure DevOps. Instead, a 500 Internal Server Error is returned to ensure that 401 errors do not leak into the application, which cause our fronted to logout our users.

Related Issue(s)

13608

Verification

Your code builds clean without any errors or warnings
Manual testing done (required)
Relevant automated test added (if you find this hard, leave it and we'll help out)

…tion

...Designer.Tests/TypedHttpClients/DelegatingHandlers/AzureDevOpsTokenDelegatingHandlerTests.cs

codecov · 2025-01-08T12:11:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (7b805ee) to head (e649d6b).
Report is 20 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14378   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files        1865     1865           
  Lines       24152    24152           
  Branches     2783     2783           
=======================================
  Hits        23083    23083           
  Misses        812      812           
  Partials      257      257

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…tps://github.com/Altinn/altinn-studio into fix/improveErrorHandlingOfAzureDevOpsIntegration

…tion

framitdavid · 2025-01-14T12:20:32Z

Tested Ok

coderabbitai · 2025-01-14T12:20:47Z

Warning

Rate limit exceeded

@framitdavid has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7b805ee and e649d6b.

📒 Files selected for processing (3)

backend/src/Designer/TypedHttpClients/DelegatingHandlers/AzureDevOpsTokenDelegatingHandler.cs (1 hunks)
backend/src/Designer/TypedHttpClients/TypedHttpClientRegistration.cs (2 hunks)
backend/tests/Designer.Tests/TypedHttpClients/DelegatingHandlers/AzureDevOpsTokenDelegatingHandlerTests.cs (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

added DelegationHandler for AzureDevOps response

f517fd4

github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. backend labels Jan 8, 2025

Merge branch 'main' into fix/improveErrorHandlingOfAzureDevOpsIntegra…

9de3691

…tion

github-advanced-security bot found potential problems Jan 8, 2025

View reviewed changes

framitdavid marked this pull request as draft January 8, 2025 13:10

framitdavid and others added 3 commits January 8, 2025 15:01

register correctly

24d6f7d

Merge branch 'fix/improveErrorHandlingOfAzureDevOpsIntegration' of ht…

68d3e8c

…tps://github.com/Altinn/altinn-studio into fix/improveErrorHandlingOfAzureDevOpsIntegration

Merge branch 'main' into fix/improveErrorHandlingOfAzureDevOpsIntegra…

e649d6b

…tion

framitdavid marked this pull request as ready for review January 8, 2025 14:13

framitdavid linked an issue Jan 8, 2025 that may be closed by this pull request

Improve error handling for expired tokens #13608

Closed

mirkoSekulic approved these changes Jan 13, 2025

View reviewed changes

framitdavid temporarily deployed to dev January 14, 2025 12:03 — with GitHub Actions Inactive

framitdavid temporarily deployed to dev January 14, 2025 12:12 — with GitHub Actions Inactive

framitdavid added the skip-manual-testing PRs that do not need to be tested manually label Jan 14, 2025

github-actions bot approved these changes Jan 14, 2025

View reviewed changes

framitdavid merged commit 6b86ab2 into main Jan 14, 2025
26 checks passed

framitdavid deleted the fix/improveErrorHandlingOfAzureDevOpsIntegration branch January 14, 2025 12:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(designer): Prevent propagation of 401 Unauthorized status from Azure DevOps #14378

fix(designer): Prevent propagation of 401 Unauthorized status from Azure DevOps #14378

framitdavid commented Jan 8, 2025 •

edited

Loading

codecov bot commented Jan 8, 2025 •

edited

Loading

framitdavid commented Jan 14, 2025

coderabbitai bot commented Jan 14, 2025

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

fix(designer): Prevent propagation of 401 Unauthorized status from Azure DevOps #14378

fix(designer): Prevent propagation of 401 Unauthorized status from Azure DevOps #14378

Conversation

framitdavid commented Jan 8, 2025 • edited Loading

Description

Related Issue(s)

Verification

codecov bot commented Jan 8, 2025 • edited Loading

Codecov Report

framitdavid commented Jan 14, 2025

coderabbitai bot commented Jan 14, 2025

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

framitdavid commented Jan 8, 2025 •

edited

Loading

codecov bot commented Jan 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)